Fix size estimation for MPEG-4 transport streams. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number of programs that TiVo deletes upon their transfer. TiVo requests the expected transfer size *before* it tries to actually transfer a file, and it does not send a desired MIME type along with that request. When that MIME type is missing and the vCodec is "h264", tivo_compatible_video() returned false -- which resulted in __est_size() estimating the size as if it will transcode the video. And, without also having this fix in tivo_compatible_container(), that estimated size can be 2-3 times too big because the bitrate may not reflect what's in the actual file.
|
It would probably make sense to condition this assumption of compatibility on the model of the requesting TiVo. |
|
Ah, that makes sense. I was about to suggest that you could fix it in a better way if you want. I was aiming for something simple, and I'm not a huge python user. BTW, the context for this is in https://www.tivocommunity.com/community/index.php?threads/working-details-of-going-away-soon-space-needed-deletes.560372/ |
… in my latest change.
|
Cool, I found that is_ts_capable() function and added a call to that. Feel free to scrap this all and do something else, of course. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can reduce the number of programs that TiVo deletes upon their transfer.
TiVo requests the expected transfer size before it tries to actually transfer
a file, and it does not send a desired MIME type along with that request. When
that MIME type is missing and the vCodec is "h264", tivo_compatible_video()
returned false -- which resulted in __est_size() estimating the size as if it
will transcode the video. And, without also having this fix in
tivo_compatible_container(), that estimated size can be 2-3 times too big
because the bitrate may not reflect what's in the actual file.